[[sat4j-dev]] [ sat4j-Bugs-308859 ] bundle jars contain different contents when build with PDE Build

[<noreply@xxxxxxxxxxxxxxxxxxx>]

Bugs item #308859, was opened at 13/03/2008 15:58
You can respond by visiting: 
http://forge.objectweb.org/tracker/?func=detail&atid=350289&aid=308859&group_id=228

Category: core
Group: None
>Status: Closed
Resolution: None
Priority: 5
Submitted By: Andrew Overholt (overholt)
Assigned to: Daniel Le Berre (leberre)
Summary: bundle jars contain different contents when build with PDE Build

Initial Comment:
Hi,

I'm planning on making a sat4j package (RPM) for Fedora. I used PDE Build
(Eclipse's build technology) to build the core and pb bundles.  I ended up 
with
differences from the bundle jars distributed as part of Eclipse (presumably
taken directly from your downloads).  Here are the differences:

core
====

your build:
- no about.html at root
- many package.html files at various levels of the hierarchy
- no org/sat4j/minisat/restarts/toto.jpage
- no plugin.properties at root

built by pde:
- about.html at root
- no package.html files
- org/sat4j/minisat/restarts/toto.jpage exists
- plugin.properties at root

pb
==

your build:
- no about.html at root
- org/sat4j/pb/constraints/pb/package.html exists
- package.html at root exists
- no plugin.properties at root

built by pde:
- about.html at root
- no package.html files
- plugin.properties at root

I mentioned this to Pascal and he said:

"The right combination is, 'the package.html' does not need to be in the
package, the toto.jpage file should not be included anywhere, the about.html
and plugin.properties should be included in both"

I would provide a patch to build.properties, but I think maybe the .jpage file
should just be removed from CVS or at least from the src.zip for core.  I'm 
not
sure how the jars you provide are built.  Do you want me to investigate a
patch?  Thanks.

----------------------------------------------------------------------

>Comment By: Daniel Le Berre (leberre)
Date: 14/03/2008 20:38

Message:
connecté 
user_id=4369

Good. So I close the bug now :)

I will upload that build file to the download section.

Take care,

--Daniel


----------------------------------------------------------------------

Comment By: Andrew Overholt (overholt)
Date: 14/03/2008 20:05

Message:
Logged In: YES 
user_id=14678

Hi Daniel,

Thanks again.  I have verified that I can generate the exact
same contents from the tag you created.  I really appreciate
your promptness here.  I will submit the package for Fedora
soon and will updated it with future RCs/2.0 final.  I will
then use it when I get Eclipse 3.4 packaged.

Andrew

----------------------------------------------------------------------

Comment By: Daniel Le Berre (leberre)
Date: 14/03/2008 19:50

Message:
connecté 
user_id=4369

Andrew,

I fixed the first issue in the enclosed build file (2.4).

Regarding the second, I wrote that class this WE to allow
Pascal to have a cleaner code on his side (I did some
refactoring to hide some details from the end user after RC5).

I added a tag property to let you gather exactly the same
code than the RC5 one.

Just use it that way:

ant -f build-2.4.xml -Dtag=INTEGRATION_P2

I should be ok now :)

--Daniel

----------------------------------------------------------------------

Comment By: Andrew Overholt (overholt)
Date: 14/03/2008 19:04

Message:
Logged In: YES 
user_id=14678

Hi Daniel,

Thanks for your prompt attention!  I tried building with
your build-2.3.xml and got two differences between my PDE
Build-built jars and yours:

- both of my core and pb jars have overview.html files at
their roots
- my freshly-built pb jar from your ant file contains
org/sat4j/pb/OptToPBSATAdapter.class which is not in my PDE
Build-generated pb jar

Thanks,

Andrew

----------------------------------------------------------------------

Comment By: Daniel Le Berre (leberre)
Date: 13/03/2008 17:33

Message:
connecté 
user_id=4369

Andrew, 

I just removed org/sat4j/minisat/restarts/toto.jpage from CVS.

You should have exactly the same content with PDE and my
build file now.

--Daniel

----------------------------------------------------------------------

Comment By: Daniel Le Berre (leberre)
Date: 13/03/2008 17:12

Message:
connecté 
user_id=4369

Andrew,

Thanks for pointing that out.

I am using an ant script to build the files.

I just updated that build file to mimic PDE, following
Pascal advices.

Since it grabs SAT4J code from anonymous CVS, you can use it
too to check its behavior.



----------------------------------------------------------------------

You can respond by visiting: 
http://forge.objectweb.org/tracker/?func=detail&atid=350289&aid=308859&group_id=228