Ok, I will commit again later
and add all necessary comments, correct the code style
======== 2008-10-31 21:16:44 您在来信中写道：
much better !!
Don't you think that this is much more readable
like this ?
Having clear diff will ease the life of guys wanting
to comment your changes (like me :) ).
1. Style style sytle,
you're always missing tabulations. Please make sure to commit files with
And, as you've subscribed to the list, you should see
clearly (do you ?), in the commit message, that there is something wrong
in regard to alignment. In that case, you should fix that and commit the
new version quickly.
2. Commit's comment
Do you think that
this commit message summarize what you have done ? I've seen that you've
modified the bnd file, but what is of some interest to me is the "why
For example, in this case, is this only a style operation (I mean,
you just aligned the embed-dependencies without adding or removing some)
3. Why do you have imports on carol ? And why 2 times the
"same" package ?
Again, this is something that could be explained by
some words on the commit message
4. Concerning the list of
embed-dependencies, I'm having doubts about the following:
jaxb-impl : We have a bundle that already provides JAXB
* jotm-*: same reason
* jsp-api is provided by
* jta, mail, mx4j, xalan, xercesImpl, xml-apis,
slf4j-api: that should be provided by the gateway (JOnAS)
compendium, apache-solr-analyzer, howl-logger, why do you need them
In brief, this list could (and should) be reduced
- 2008-10-31 13:55:47 +0100 (Fri, 31 Oct 2008)
Modify the bnd file.
(15690 => 15691)
--- jonas/trunk/jonas/modules/services/webservices/axis2/src/main/resources/META-INF/jonas-webservices-axis2.bnd 2008-10-31 08:55:43 UTC (rev 15690)
+++ jonas/trunk/jonas/modules/services/webservices/axis2/src/main/resources/META-INF/jonas-webservices-axis2.bnd 2008-10-31 12:55:47 UTC (rev 15691)
@@ -65,7 +65,54 @@
= = = = = = = = = = = = = = = = = = = = = =
Institute of Software
School of Electronics
Engineering & Computer Science