|
hi,Guillaume :
Ok, I will commit again later
and add all necessary comments, correct the code style
======== 2008-10-31 21:16:44 您在来信中写道：
========
Ahhh,
much better !!
Don't you think that this is much more readable
like this ?
Having clear diff will ease the life of guys wanting
to comment your changes (like me :) ).
1. Style style sytle,
you're always missing tabulations. Please make sure to commit files with
only spaces.
And, as you've subscribed to the list, you should see
clearly (do you ?), in the commit message, that there is something wrong
in regard to alignment. In that case, you should fix that and commit the
new version quickly.
2. Commit's comment
Do you think that
this commit message summarize what you have done ? I've seen that you've
modified the bnd file, but what is of some interest to me is the "why
?"
For example, in this case, is this only a style operation (I mean,
you just aligned the embed-dependencies without adding or removing some)
?
3. Why do you have imports on carol ? And why 2 times the
"same" package ?
Again, this is something that could be explained by
some words on the commit message
4. Concerning the list of
embed-dependencies, I'm having doubts about the following:
*
jaxb-impl : We have a bundle that already provides JAXB
implementation
* jotm-*: same reason
* jsp-api is provided by
javaee-api bundle
* jta, mail, mx4j, xalan, xercesImpl, xml-apis,
slf4j-api: that should be provided by the gateway (JOnAS)
* osgi
compendium, apache-solr-analyzer, howl-logger, why do you need them
?
In brief, this list could (and should) be reduced
...
Cheers
--Guillaume
xiaoda08@xxxxxxxxxxxxxx a
écrit :
- Revision
- 15691
- Author
- xiaoda
- Date
- 2008-10-31 13:55:47 +0100 (Fri, 31 Oct 2008)
Log MessageModify the bnd file.
Modified Paths
Diff
Modified:
jonas/trunk/jonas/modules/services/webservices/axis2/src/main/resources/META-INF/jonas-webservices-axis2.bnd
(15690 => 15691)
--- jonas/trunk/jonas/modules/services/webservices/axis2/src/main/resources/META-INF/jonas-webservices-axis2.bnd 2008-10-31 08:55:43 UTC (rev 15690)
+++ jonas/trunk/jonas/modules/services/webservices/axis2/src/main/resources/META-INF/jonas-webservices-axis2.bnd 2008-10-31 12:55:47 UTC (rev 15691)
@@ -65,7 +65,54 @@
!org.apache.xml.resolver.*,\
!org.slf4j.impl,\
org.ow2.easybeans.container,\
+ org.objectweb.carol.jndi.spi,\
+ org.ow2.carol.jndi.spi,\
*
+
Private-Package org.ow2.jonas.ws.axis2.*
-Embed-Dependency *;scope=compile|runtime;artifactId=!ant*|wsdl4j|activation|axis-jaxrpc|axis2-jaxws-api|axis2-jws-api|axis2-saaj-api|altlr|ca*|cglib*|asm*|easybeans*|ehcache|geronimo*|hibernate*|commons-modeler|concurrent|dom4j|hsqldb|icu4j|jacc|jakarta*|java*|jboss*|jcup|jdom|jonas*|joram*|jsf*|jsp-api|jsr*|junit|monolog*|org.apache*|ow2*|p*|q*|servlet-api|util*|wstx-asl|xmlParserAPIs|xom|jaxb-impl|jaxb-api|jaxb-xjc
+
+Embed-Dependency annogen,\
+ apache-solr-analyzer,\
+ axiom-api,\
+ axiom-dom,\
+ axiom-impl,\
+ axis2-adb,\
+ axis2-jaxws,\
+ axis2-kernel,\
+ axis2-metadata,\
+ axis2-saaj,\
+ backport-util-concurrent,\
+ commons-codec,\
+ commons-collections,\
+ commons-fileupload,\
+ commons-httpclient,\
+ commons-io,\
+ commons-logging,\
+ commons-logging-api,\
+ howl-logger,\
+ httpcore,\
+ httpcore-nio,\
+ httpcore-niossl,\
+ jaxb-impl,\
+ jaxen,\
+ jotm,\
+ jotm_jrmp_stubs,\
+ jsp-api,\
+ jta,\
+ log4j,\
+ lucene-core,\
+ mail,\
+ mx4j-jmx,\
+ neethi,\
+ osgi_R4_compendium,\
+ slf4j-api,\
+ stax,\
+ stax-api,\
+ woden,\
+ xalan,\
+ xercesImpl,\
+ xml-apis,\
+ XmlSchema,\
+ util-annotation-processor
+
Embed-Transitive true
|
= = = = = = = = = = = = = = = = = = = = = =
致
礼！
XiaoDa mailto:http://xiaoda08@xxxxxxxxxxxxxx
____________________________________________________
Institute of Software
School of Electronics
Engineering & Computer Science
Peking University
Beijing, 100871,
P.R.China
Tel :
(86-10)62757801
____________________________________________________
2008-11-03
|
