[fractal-commits] [7810] sandbox/ervalerio/fractal-bf/core/src/main/java/org/objectweb/fractal/bf: cleanup interface and impl (removing unnecessary bind(...)taking BindHints as parameter, which only belongs to plugins APIs)

[valerio.schiavoni@xxxxxxxxx]

Title: [7810] sandbox/ervalerio/fractal-bf/core/src/main/java/org/objectweb/fractal/bf: cleanup interface and impl (removing unnecessary bind(...) taking BindHints as parameter, which only belongs to plugins APIs)

Revision

7810

Author

ervalerio

Date

2008-05-30 09:42:09 +0200 (Fri, 30 May 2008)

Log Message

cleanup interface and impl (removing unnecessary bind(...) taking BindHints as parameter, which only belongs to plugins APIs)

Modified Paths

• sandbox/ervalerio/fractal-bf/core/src/main/java/org/objectweb/fractal/bf/BindingFactory.java
• sandbox/ervalerio/fractal-bf/core/src/main/java/org/objectweb/fractal/bf/BindingFactoryImpl.java

Diff

Modified: sandbox/ervalerio/fractal-bf/core/src/main/java/org/objectweb/fractal/bf/BindingFactory.java (7809 => 7810)

--- sandbox/ervalerio/fractal-bf/core/src/main/java/org/objectweb/fractal/bf/BindingFactory.java	2008-05-29 09:30:00 UTC (rev 7809)
+++ sandbox/ervalerio/fractal-bf/core/src/main/java/org/objectweb/fractal/bf/BindingFactory.java	2008-05-30 07:42:09 UTC (rev 7810)
@@ -45,21 +45,6 @@
 			throws BindingFactoryException;
 
 	/**
-	 * Establish a remote binding using the specified export identifier.
-	 * 
-	 * @param component
-	 *            the component owning the interface to bind
-	 * @param clientItf
-	 *            the name of the client interface to bind
-	 * @param exportId
-	 *            the {@link ExportId} to use for the bind
-	 * @throws BindingFactoryException
-	 *             if some error occurs while binding.
-	 */
-	void bind(Component component, String clientItf, BindHints hints)
-			throws BindingFactoryException;
-
-	/**
 	 * Establish a remote binding using the specified parameters.
 	 * 
 	 * @param component

Modified: sandbox/ervalerio/fractal-bf/core/src/main/java/org/objectweb/fractal/bf/BindingFactoryImpl.java (7809 => 7810)

--- sandbox/ervalerio/fractal-bf/core/src/main/java/org/objectweb/fractal/bf/BindingFactoryImpl.java	2008-05-29 09:30:00 UTC (rev 7809)
+++ sandbox/ervalerio/fractal-bf/core/src/main/java/org/objectweb/fractal/bf/BindingFactoryImpl.java	2008-05-30 07:42:09 UTC (rev 7810)
@@ -144,10 +144,6 @@
 		hints.put("itfName", itfName);
 		plugin.finalizeSkeleton(skel, hints);
 
-		// 6) return the export id created by this plugin
-		// ExportId exportId = null;
-		// exportId = plugin.createExportId(itfName, serverComponent, hints);
-
 		try {
 			String compName = Fractal.getNameController(serverComponent)
 					.getFcName();
@@ -155,7 +151,7 @@
 					+ itfName + " owned by component [" + compName
 					+ "] with the following parameters: " + hints);
 		} catch (NoSuchInterfaceException e) {
-			log.info("Component [unknown] exports its interface " + itfName
+			log.info("Component [unnamed] exports its interface " + itfName
 					+ " with the following parameters: " + hints);
 
 		}
@@ -200,22 +196,6 @@
 	}
 
 	/**
-	 * Bind the client interface using the {@link ExportId}.
-	 * 
-	 * @param component
-	 *            the component to bind
-	 * @param clientItf
-	 *            the client interface to bind
-	 * @param exportId
-	 *            the export id to use for the bind
-	 */
-	public void bind(Component component, String clientItf, BindHints exportId)
-			throws BindingFactoryException {
-		throw new UnsupportedOperationException(
-				"This operation is not implemented yet");
-	}
-
-	/**
 	 * @see org.objectweb.fractal.bf.BindingFactory#bind(org.objectweb.fractal.api.Component,
 	 *      java.lang.String, java.util.Map)
 	 */
@@ -257,9 +237,9 @@
 			// get the parent of the client component
 			Component parentOfClient = SuperControllerHelper
 					.getTopMostComponent(clientComponent); /*
-															 * BindingFactoryUtil
-															 * .directParentOf(clientComponent);
-															 */
+			 * BindingFactoryUtil
+			 * .directParentOf(clientComponent);
+			 */
 
 			// insert the stub into same composite of the client
 			Fractal.getContentController(parentOfClient)
@@ -272,6 +252,17 @@
 			// of the stub
 			Fractal.getBindingController(clientComponent).bindFc(clientItf,
 					stub.getFcInterface(clientItf));
+			log.fine("Client interface: " + clientItf + " owned by: "
+					+ clientComponent
+					+ " is now bound to the generated stub component:" + stub
+					+ " throught its server interface:" + clientItf);
+			// final LifeCycleController stubLC = Fractal
+			// .getLifeCycleController(stub);
+			// log.finest("Stub lifecycle state:" + stubLC.getFcState()
+			// + ". Calling startFc()..");
+			// stubLC.startFc();
+			// log.finest("Stub lifecycle state after startFc:"
+			// + stubLC.getFcState());
 
 		} catch (Exception e) {
 			throw new BindingFactoryException(